fix: [UIE-10244] - Connection Pools table page size#13448
Open
hana-akamai wants to merge 5 commits intolinode:developfrom
Open
fix: [UIE-10244] - Connection Pools table page size#13448hana-akamai wants to merge 5 commits intolinode:developfrom
hana-akamai wants to merge 5 commits intolinode:developfrom
Conversation
hana-akamai
added
Bug
| @@ -1,3 +1,4 @@ | |||
| export const MIN_PAGE_SIZE = 25; | |||
|
|
|||
| export const DEFAULT_PAGE_SIZES = [MIN_PAGE_SIZE, 50, 75, 100]; | |||
Member
There was a problem hiding this comment.
Should this be somewhere else? It's not obvious to me what the difference is between DEFAULT_PAGE_SIZES and PAGE_SIZES below
Member
There was a problem hiding this comment.
Maybe PAGE_SIZES can be removed and we can just use DEFAULT_PAGE_SIZES only? From what I remember, we don't let people select Infinity/All anymore anyway
Contributor
Author
There was a problem hiding this comment.
Good point, moved DEFAULT_PAGE_SIZES to the Database constants file for now. I'm not sure if we removed the select Infinity/All - posted the question in team channel
smans-akamai
reviewed
Mar 2, 2026
smans-akamai
approved these changes
Mar 2, 2026
Contributor
smans-akamai
left a comment
smans-akamai
left a comment
There was a problem hiding this comment.
tested out the changes and it looks great! Thanks for addressing my feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Remove Infinity option from the Database Connection Pools table page size dropdown
Changes 🔄
DEFAULT_PAGE_SIZESconstant without Infinity to PaginationFooter constantsScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Next release
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)